Backend hotfixes #249
Merged
Backend hotfixes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed new default env parameters for message retrival limiting.
AlexanderWangY
requested changes
Sep 6, 2024
AlexanderWangY
approved these changes
Sep 8, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not completely fixed yet but I discovered that the backend would crash when a new user connected due to an invalid attribute for Observer in index.ts. I've fixed it so that the app doesn't crash now, but for some reason message retrieval doesn't work for me. I may create an issue for this.
For the same function I also added two default env parameters for limiting message retrieval. Notes these aren't really tested because message retrieval currently doesn't seem to work.
Also made an addition to the backend gitignore in case of a misunderstanding of the documentation.